linux-kernel - Re: [PATCH -next] scsi: megaraid_sas: remove set but not used variable 'sge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Jun 2019 12:06:01 +0530
From:   Sumit Saxena <sumit.saxena@...adcom.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Kashyap Desai <kashyap.desai@...adcom.com>,
        Shivasharan Srikanteshwara 
        <shivasharan.srikanteshwara@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux SCSI List <linux-scsi@...r.kernel.org>,
        "PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...adcom.com>
Subject: Re: [PATCH -next] scsi: megaraid_sas: remove set but not used
 variable 'sge_sz'

On Sat, May 25, 2019 at 6:07 PM YueHaibing <yuehaibing@...wei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_create_frame_pool:
> drivers/scsi/megaraid/megaraid_sas_base.c:4124:6: warning: variable sge_sz set but not used [-Wunused-but-set-variable]
>
> It's not used any more since
> commit 200aed582d61 ("megaraid_sas: endianness related bug fixes and code optimization")
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Acked-by: Sumit Saxena <sumit.saxena@...adcom.com>

> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index b26991dcf137..25281a2eb424 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -4121,22 +4121,11 @@ static int megasas_create_frame_pool(struct megasas_instance *instance)
>  {
>         int i;
>         u16 max_cmd;
> -       u32 sge_sz;
>         u32 frame_count;
>         struct megasas_cmd *cmd;
>
>         max_cmd = instance->max_mfi_cmds;
>
> -       /*
> -        * Size of our frame is 64 bytes for MFI frame, followed by max SG
> -        * elements and finally SCSI_SENSE_BUFFERSIZE bytes for sense buffer
> -        */
> -       sge_sz = (IS_DMA64) ? sizeof(struct megasas_sge64) :
> -           sizeof(struct megasas_sge32);
> -
> -       if (instance->flag_ieee)
> -               sge_sz = sizeof(struct megasas_sge_skinny);
> -
>         /*
>          * For MFI controllers.
>          * max_num_sge = 60
> --
> 2.17.1
>
>