linux-kernel - Re: [PATCH 2/2] drm/meson: fix G12A primary plane disabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c66e11b6-bf1b-8b6e-4110-42b20b879d3c@baylibre.com>
Date:   Fri, 7 Jun 2019 10:07:15 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Kevin Hilman <khilman@...libre.com>,
        dri-devel@...ts.freedesktop.org
Cc:     linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] drm/meson: fix G12A primary plane disabling

On 06/06/2019 19:30, Kevin Hilman wrote:
> Neil Armstrong <narmstrong@...libre.com> writes:
> 
>> The G12A Primary plane was disabled by writing in the OSD1 configuration
>> registers, but this caused the plane blender to stall instead of continuing
>> blended only the overlay plane.
> 
> grammar nit: "...instead of continuing to blend only the overlay plane."

Fixed while applying on drm-misc-fixes

> 
>> Fix this by disabling the OSD1 plane in the blender registers, and also
>> enabling it back using the same register.
>>
>> Fixes: 490f50c109d1 ("drm/meson: Add G12A support for OSD1 Plane")
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> 
> Reviewed-by: Kevin Hilman <khilman@...libre.com>
> 
> As noted elsewhere, this driver is also full of magic constants used in
> register writes which makes reviewing this kind of change for
> correctness that much more difficult, but since that's already been
> pointed out elsewhere, and it's already on your TODO list, it should not
> block this important fix.

Yep, it's the top priority now.

Thanks,

Neil

> 
> Kevin
>