linux-kernel - Re: [PATCH 1/2] habanalabs: add rate-limit to an error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf13a33KvMQ=beOkKtaBaKtJn_JqZF5av-bSgpPpBnDSO3Q@mail.gmail.com>
Date:   Fri, 7 Jun 2019 11:08:22 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] habanalabs: add rate-limit to an error message

On Thu, Jun 6, 2019 at 9:54 PM Joe Perches <joe@...ches.com> wrote:
>
> On Thu, 2019-06-06 at 15:20 +0300, Oded Gabbay wrote:
> > This patch changes the print of an error message about mis-configuration
> > of the debug infrastructure to be rate-limited, to prevent flooding of
> > kernel log, as these configuration requests can come at a high rate.
> []
> > diff --git a/drivers/misc/habanalabs/habanalabs_ioctl.c b/drivers/misc/habanalabs/habanalabs_ioctl.c
> []
> > @@ -255,7 +255,7 @@ static int hl_debug_ioctl(struct hl_fpriv *hpriv, void *data)
> >       case HL_DEBUG_OP_SPMU:
> >       case HL_DEBUG_OP_TIMESTAMP:
> >               if (!hdev->in_debug) {
> > -                     dev_err(hdev->dev,
> > +                     dev_err_ratelimited(hdev->dev,
> >                               "Rejecting debug configuration request because device not in debug mode\n");
> >                       return -EFAULT;
> >               }
>
> Perhaps this should be dev_dbg
>
>
But this a basic error. I prefer to give visibility to the user in such a case.

Thanks,
Oded