linux-kernel - Re: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190607000937.GA13090@tower.DHCP.thefacebook.com>
Date:   Fri, 7 Jun 2019 00:09:43 +0000
From:   Roman Gushchin <guro@...com>
To:     Daniel Borkmann <daniel@...earbox.net>
CC:     "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Kernel Team <Kernel-team@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Yonghong Song <yhs@...com>
Subject: Re: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use
 bpf_skb_cgroup_id() helper

On Fri, Jun 07, 2019 at 02:00:20AM +0200, Daniel Borkmann wrote:
> On 06/06/2019 10:30 PM, Roman Gushchin wrote:
> > Currently bpf_skb_cgroup_id() is not supported for CGROUP_SKB
> > programs. An attempt to load such a program generates an error
> > like this:
> > 
> >     libbpf:
> >     0: (b7) r6 = 0
> >     ...
> >     9: (85) call bpf_skb_cgroup_id#79
> >     unknown func bpf_skb_cgroup_id#79
> > 
> > There are no particular reasons for denying it, and we have some
> > use cases where it might be useful.
> > 
> > So let's add it to the list of allowed helpers.
> > 
> > Signed-off-by: Roman Gushchin <guro@...com>
> > Cc: Yonghong Song <yhs@...com>
> > Cc: Alexei Starovoitov <ast@...nel.org>
> > Cc: Daniel Borkmann <daniel@...earbox.net>
> 
> Applied, thanks!

Thank you, Daniel!