linux-kernel - Re: [PATCH v2] kernel: module: Use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190607085746.GA4211@linux-8ccs>
Date:   Fri, 7 Jun 2019 10:57:46 +0200
From:   Jessica Yu <jeyu@...nel.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kernel: module: Use struct_size() helper

+++ Gustavo A. R. Silva [06/06/19 13:18 -0500]:
>One of the more common cases of allocation size calculations is finding
>the size of a structure that has a zero-sized array at the end, along
>with memory for some number of elements for that array. For example:
>
>struct module_sect_attrs {
>	...
>        struct module_sect_attr attrs[0];
>};
>
>Make use of the struct_size() helper instead of an open-coded version
>in order to avoid any potential type mistakes.
>
>So, replace the following form:
>
>sizeof(*sect_attrs) + nloaded * sizeof(sect_attrs->attrs[0]
>
>with:
>
>struct_size(sect_attrs, attrs, nloaded)
>
>This code was detected with the help of Coccinelle.
>
>Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>---
>Changes in v2:
> - Update changelog text by adding a better description for
>   the motivation and usage of the struct_size() helper.

Applied. Thanks a lot!

Jessica