linux-kernel - [PATCH net-next 0/7] bonding: clean up and standarize logging printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190607145933.37058-1-jarod@redhat.com>
Date:   Fri,  7 Jun 2019 10:59:25 -0400
From:   Jarod Wilson <jarod@...hat.com>
To:     linux-kernel@...r.kernel.org
Cc:     Jarod Wilson <jarod@...hat.com>, Joe Perches <joe@...ches.com>,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org
Subject: [PATCH net-next 0/7] bonding: clean up and standarize logging printks

This set improves a few somewhat terse bonding debug messages, fixes some
errors in others, and then standarizes the majority of them, using new
slave_* printk macros that wrap around netdev_* to ensure both master
and slave information is provided consistently, where relevant. This set
proves very useful in debugging issues on hosts with multiple bonds.

I've run an array of LNST tests over this set, creating and destroying
quite a few different bonds of the course of testing, fixed the little
gotchas here and there, and everything looks stable and reasonable to me,
but I can't guarantee I've tested every possible message and scenario to
catch every possible "slave could be NULL" case.

Jarod Wilson (7):
  bonding: improve event debug usability
  bonding: fix error messages in bond_do_fail_over_mac
  bonding: add slave_foo printk macros
  bonding/main: convert to using slave printk macros
  bonding/802.3ad: convert to using slave printk macros
  bonding/alb: convert to using slave printk macros
  bonding/options: convert to using slave printk macros

 drivers/net/bonding/bond_3ad.c     | 222 +++++++++++----------
 drivers/net/bonding/bond_alb.c     |  30 +--
 drivers/net/bonding/bond_main.c    | 309 +++++++++++++----------------
 drivers/net/bonding/bond_options.c |  30 ++-
 include/net/bonding.h              |   9 +
 5 files changed, 293 insertions(+), 307 deletions(-)

Suggested-by: Joe Perches <joe@...ches.com>
CC: Jay Vosburgh <j.vosburgh@...il.com>
CC: Veaceslav Falico <vfalico@...il.com>
CC: Andy Gospodarek <andy@...yhouse.net>
CC: netdev@...r.kernel.org
Signed-off-by: Jarod Wilson <jarod@...hat.com>

-- 
2.20.1