linux-kernel - Re: [PATCH] drivers/ata: remove flood "Enabling discard_zeroes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1sgsli9wh.fsf@oracle.com>
Date:   Fri, 07 Jun 2019 13:26:54 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Dmitry Monakhov <dmtrmonakhov@...dex-team.ru>
Subject: Re: [PATCH] drivers/ata: remove flood "Enabling discard_zeroes_data"


Konstantin,

> Printing this at each SCSI READ_CAPACITY command is too verbose.
>
> Flag "discard_zeroes_data" is deprecated since commit 48920ff2a5a9
> ("block: remove the discard_zeroes_data flag").

> -			    dev->horkage & ATA_HORKAGE_ZERO_AFTER_TRIM) {
> -				ata_dev_info(dev, "Enabling discard_zeroes_data\n");
> +			    dev->horkage & ATA_HORKAGE_ZERO_AFTER_TRIM)
>  				rbuf[14] |= 0x40; /* LBPRZ */

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering