linux-kernel - Re: [PATCH] dma: jz4780: Make probe function __init_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1559989429.1815.7@crapouillou.net>
Date:   Sat, 08 Jun 2019 12:23:49 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
        Vinod Koul <vkoul@...nel.org>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, od@...c.me
Subject: Re: [PATCH] dma: jz4780: Make probe function __init_or_module

I misunderstood what __init_or_module was for. Please ignore this 
patch. Sorry for the noise.


Le ven. 7 juin 2019 à 18:07, Paul Cercueil <paul@...pouillou.net> a 
écrit :
> This allows the probe function to be dropped after the kernel finished
> its initialization, in the case where the driver was not compiled as a
> module.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---
>  drivers/dma/dma-jz4780.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index 7204fdeff6c5..b2f7e6660ad6 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -815,7 +815,7 @@ static struct dma_chan 
> *jz4780_of_dma_xlate(struct of_phandle_args *dma_spec,
>  	}
>  }
> 
> -static int jz4780_dma_probe(struct platform_device *pdev)
> +static int __init_or_module jz4780_dma_probe(struct platform_device 
> *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	const struct jz4780_dma_soc_data *soc_data;
> @@ -966,7 +966,7 @@ static int jz4780_dma_probe(struct 
> platform_device *pdev)
>  	return ret;
>  }
> 
> -static int jz4780_dma_remove(struct platform_device *pdev)
> +static int __exit jz4780_dma_remove(struct platform_device *pdev)
>  {
>  	struct jz4780_dma_dev *jzdma = platform_get_drvdata(pdev);
>  	int i;
> --
> 2.21.0.593.g511ec345e18
>