linux-kernel - Re: [RFC net-next 2/2] net: stmmac: Convert to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190608184601.GA22700@lunn.ch>
Date:   Sat, 8 Jun 2019 20:46:01 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Jose Abreu <Jose.Abreu@...opsys.com>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, Joao Pinto <Joao.Pinto@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Russell King <linux@...linux.org.uk>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [RFC net-next 2/2] net: stmmac: Convert to phylink

> I am not exactly sure removing this is strictly equivalent here, but the
> diff makes it hard to review.

Yes, diff is doing a poor job here. I already asked Jose if a better
diff could be produced by passing extra options.

> - add support for PHYLINK (parts of this patch) but without plugging it
> into the probe/connect path just yet

I don't think this is going to make the diff any better.

I might actually just apply the patches and look at the resulting
files.

  Andrew