| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190608044339.115026-10-saravanak@google.com>
Date: Fri, 7 Jun 2019 21:43:39 -0700
From: Saravana Kannan <saravanak@...gle.com>
To: Georgi Djakov <georgi.djakov@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
Stephen Boyd <sboyd@...nel.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc: Saravana Kannan <saravanak@...gle.com>,
Rajendra Nayak <rnayak@...eaurora.org>,
Jordan Crouse <jcrouse@...eaurora.org>,
vincent.guittot@...aro.org, bjorn.andersson@...aro.org,
amit.kucheria@...aro.org, seansw@....qualcomm.com,
daidavid1@...eaurora.org, evgreen@...omium.org,
sibis@...eaurora.org, kernel-team@...roid.com,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH v1 9/9] interconnect: Add devfreq support
Add a icc_create_devfreq() and icc_remove_devfreq() to create and remove
devfreq devices for interconnect paths. A driver can create/remove devfreq
devices for the interconnects needed for its device by calling these APIs.
This would allow various devfreq governors to work with interconnect paths
and the device driver itself doesn't have to actively manage the bandwidth
votes for the interconnects.
Signed-off-by: Saravana Kannan <saravanak@...gle.com>
---
drivers/interconnect/Makefile | 2 +-
drivers/interconnect/icc-devfreq.c | 145 +++++++++++++++++++++++++++++
include/linux/interconnect.h | 11 +++
3 files changed, 157 insertions(+), 1 deletion(-)
create mode 100644 drivers/interconnect/icc-devfreq.c
diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile
index 28f2ab0824d5..ddfb65b7fa55 100644
--- a/drivers/interconnect/Makefile
+++ b/drivers/interconnect/Makefile
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0
-icc-core-objs := core.o
+icc-core-objs := core.o icc-devfreq.o
obj-$(CONFIG_INTERCONNECT) += icc-core.o
obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/
diff --git a/drivers/interconnect/icc-devfreq.c b/drivers/interconnect/icc-devfreq.c
new file mode 100644
index 000000000000..f88b267d281e
--- /dev/null
+++ b/drivers/interconnect/icc-devfreq.c
@@ -0,0 +1,145 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * A devfreq device driver for interconnect paths
+ *
+ * Copyright (C) 2019 Google, Inc
+ */
+
+#include <linux/devfreq.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/pm_opp.h>
+#include <linux/slab.h>
+#include <linux/interconnect.h>
+#include <linux/limits.h>
+
+struct icc_devfreq {
+ struct device icc_dev;
+ struct icc_path *path;
+ struct devfreq_dev_profile dp;
+ struct devfreq *df;
+ unsigned long peak_bw;
+ unsigned long avg_bw;
+};
+
+static int icc_target(struct device *dev, unsigned long *freq,
+ u32 flags)
+{
+ struct icc_devfreq *d = dev_get_drvdata(dev);
+ struct dev_pm_opp *opp;
+ unsigned long peak_bw, avg_bw;
+
+ opp = devfreq_recommended_opp(dev, &peak_bw, flags);
+ if (IS_ERR(opp)) {
+ dev_err(dev, "Failed to find opp for %lu KHz\n", *freq);
+ return PTR_ERR(opp);
+ }
+ peak_bw = dev_pm_opp_get_bw(opp, &avg_bw);
+ dev_pm_opp_put(opp);
+
+ if (!icc_set_bw(d->path, avg_bw, peak_bw)) {
+ *freq = peak_bw;
+ d->peak_bw = peak_bw;
+ d->avg_bw = avg_bw;
+ }
+
+ return 0;
+}
+
+static int icc_get_dev_status(struct device *dev,
+ struct devfreq_dev_status *stat)
+{
+ struct icc_devfreq *d = dev_get_drvdata(dev);
+
+ stat->current_frequency = d->peak_bw;
+ return 0;
+}
+
+#define icc_dev_to_data(DEV) container_of((DEV), struct icc_devfreq, icc_dev)
+static void icc_dev_release(struct device *dev)
+{
+ struct icc_devfreq *d = icc_dev_to_data(dev);
+
+ kfree(d);
+}
+
+struct icc_devfreq *icc_create_devfreq(struct device *dev, char *name)
+{
+ struct icc_devfreq *d;
+ struct icc_path *path;
+ struct opp_table *opp_table;
+ struct dev_pm_opp *opp;
+ unsigned long peak_bw = U32_MAX, avg_bw = U32_MAX;
+ int err;
+
+ if (!name)
+ return ERR_PTR(-EINVAL);
+
+ path = of_icc_get(dev, name);
+ if (IS_ERR(path))
+ return (void *) path;
+
+ opp_table = icc_get_opp_table(path);
+ if (!opp_table) {
+ err = -EINVAL;
+ goto out_path;
+ }
+
+ d = kzalloc(sizeof(*d), GFP_KERNEL);
+ if (!d) {
+ err = -ENOMEM;
+ goto out_path;
+ }
+ d->path = path;
+
+ d->icc_dev.parent = dev;
+ d->icc_dev.release = icc_dev_release;
+ dev_set_name(&d->icc_dev, "%s-icc-%s", dev_name(dev), name);
+ err = device_register(&d->icc_dev);
+ if (err) {
+ put_device(&d->icc_dev);
+ goto out_path;
+ }
+
+ dev_pm_opp_add_opp_table(&d->icc_dev, opp_table);
+ opp = dev_pm_opp_find_peak_bw_floor(dev, &peak_bw);
+ peak_bw = dev_pm_opp_get_bw(opp, &avg_bw);
+ dev_pm_opp_put(opp);
+
+ if (!icc_set_bw(d->path, avg_bw, peak_bw)) {
+ d->peak_bw = peak_bw;
+ d->avg_bw = avg_bw;
+ }
+
+ d->dp.initial_freq = peak_bw;
+ d->dp.polling_ms = 0;
+ d->dp.target = icc_target;
+ d->dp.get_dev_status = icc_get_dev_status;
+ d->df = devm_devfreq_add_device(&d->icc_dev,
+ &d->dp,
+ "performance",
+ NULL);
+ if (IS_ERR(d->df)) {
+ err = PTR_ERR(d->df);
+ goto out_dev;
+ }
+
+ return d;
+out_dev:
+ put_device(&d->icc_dev);
+out_path:
+ icc_put(path);
+ return ERR_PTR(err);
+}
+EXPORT_SYMBOL_GPL(icc_create_devfreq);
+
+void icc_remove_devfreq(struct icc_devfreq *d)
+{
+ icc_put(d->path);
+ put_device(&d->icc_dev);
+}
+EXPORT_SYMBOL_GPL(icc_remove_devfreq);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("interconnect devfreq device driver");
+MODULE_AUTHOR("Saravana Kannan <saravanak@...gle.com>");
diff --git a/include/linux/interconnect.h b/include/linux/interconnect.h
index 0c0bc55f0e89..cb166cbcdf88 100644
--- a/include/linux/interconnect.h
+++ b/include/linux/interconnect.h
@@ -23,6 +23,7 @@
struct icc_path;
struct device;
+struct icc_devfreq;
#if IS_ENABLED(CONFIG_INTERCONNECT)
@@ -32,6 +33,8 @@ struct icc_path *of_icc_get(struct device *dev, const char *name);
struct opp_table *icc_get_opp_table(struct icc_path *path);
void icc_put(struct icc_path *path);
int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw);
+struct icc_devfreq *icc_create_devfreq(struct device *dev, char *name);
+void icc_remove_devfreq(struct icc_devfreq *d);
#else
@@ -61,6 +64,14 @@ static inline int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw)
return 0;
}
+static inline struct icc_devfreq *icc_create_devfreq(struct device *dev,
+ char *name)
+{
+ return NULL;
+}
+
+void icc_remove_devfreq(struct icc_devfreq *d) {}
+
#endif /* CONFIG_INTERCONNECT */
#endif /* __LINUX_INTERCONNECT_H */
--
2.22.0.rc2.383.gf4fbbf30c2-goog
Powered by blists - more mailing lists