linux-kernel - Re: [tip:ras/core] RAS/CEC: Rename count_threshold to action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190609090637.GA26453@gmail.com>
Date:   Sun, 9 Jun 2019 11:06:37 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     linux-edac@...r.kernel.org, hpa@...or.com,
        linux-kernel@...r.kernel.org, bp@...e.de, tony.luck@...el.com,
        tglx@...utronix.de
Cc:     linux-tip-commits@...r.kernel.org
Subject: Re: [tip:ras/core] RAS/CEC: Rename count_threshold to
 action_threshold


* tip-bot for Borislav Petkov <tipbot@...or.com> wrote:

> Commit-ID:  b8b5ca6600dec2a4f1e50ca9d3cf9e1d032870cd
> Gitweb:     https://git.kernel.org/tip/b8b5ca6600dec2a4f1e50ca9d3cf9e1d032870cd
> Author:     Borislav Petkov <bp@...e.de>
> AuthorDate: Sat, 20 Apr 2019 21:30:11 +0200
> Committer:  Borislav Petkov <bp@...e.de>
> CommitDate: Sat, 8 Jun 2019 17:38:17 +0200
> 
> RAS/CEC: Rename count_threshold to action_threshold
> 
> ... which is the better, more-fitting name anyway.
> 
> Tony:
>  - make action_threshold u64 due to debugfs accessors expecting u64.
>  - rename the remaining: s/count_threshold/action_threshold/g
> 
> Co-developed-by: Tony Luck <tony.luck@...el.com>
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: linux-edac <linux-edac@...r.kernel.org>

JFYI, the SOB chain is a bit messed up here, the proper chain would be:

 Signed-off-by: Borislav Petkov <bp@...e.de>
 Signed-off-by: Tony Luck <tony.luck@...el.com>
 Signed-off-by: Borislav Petkov <bp@...e.de>

This shows that the patch started out as your effort as a developer, then 
Tony enhanced it and passed it to you as maintainer.

See for example this commit for an example:

  7675104990ed ("sched: Implement lockless wake-queues")

Note that this pattern also signals the co-developed portion, so that tag 
can be dropped - but it can be kept too for extra clarity.

Thanks,

	Ingo