linux-kernel - Re: [PATCH 04/34] leds: leds-pca955x: simplify getting the adapter of a client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190609110519.GA2375@amd>
Date:   Sun, 9 Jun 2019 13:05:20 +0200
From:   Pavel Machek <pavel@....cz>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-i2c@...r.kernel.org, Dan Murphy <dmurphy@...com>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/34] leds: leds-pca955x: simplify getting the adapter
 of a client

On Sun 2019-06-09 13:03:40, Jacek Anaszewski wrote:
> Hi Wolfram,
> 
> Thank you for the patches.
> 
> On 6/8/19 12:55 PM, Wolfram Sang wrote:
> >We have a dedicated pointer for that, so use it. Much easier to read and
> >less computation involved.
> >
> >Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> >---
> >
> >Please apply to your subsystem tree.
> >
> >  drivers/leds/leds-pca955x.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> >index a9f5dad55956..460626d81c6a 100644
> >--- a/drivers/leds/leds-pca955x.c
> >+++ b/drivers/leds/leds-pca955x.c
> >@@ -432,7 +432,7 @@ static int pca955x_probe(struct i2c_client *client,
> >  	int ngpios = 0;
> >  	chip = &pca955x_chipdefs[id->driver_data];
> >-	adapter = to_i2c_adapter(client->dev.parent);
> >+	adapter = client->adapter;
> >  	pdata = dev_get_platdata(&client->dev);
> >  	if (!pdata) {
> >  		pdata =	pca955x_get_pdata(client, chip);
> >
> 
> For both 4/34 and 5/34:
> 
> Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>

4 and 5:

Acked-by: Pavel Machek <pavel@....cz>

But I wonder if it should go through the leds tree?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)