lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Jun 2019 09:42:13 +0100 From: Lee Jones <lee.jones@...aro.org> To: alokc@...eaurora.org, andy.gross@...aro.org, david.brown@...aro.org, wsa+renesas@...g-engineering.com, bjorn.andersson@...aro.org, linus.walleij@...aro.org, balbi@...nel.org, gregkh@...uxfoundation.org, ard.biesheuvel@...aro.org, jlhugo@...il.com, linux-i2c@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org, linux-usb@...r.kernel.org Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org> Subject: [PATCH v3 8/8] usb: dwc3: qcom: Improve error handling dwc3_qcom_clk_init() is called with of_count_phandle_with_args() as an argument. If of_count_phandle_with_args() returns an error, the number of clocks will be a negative value and will lead to undefined behaviour. Ensure we check for an error before attempting to blindly use the value. Signed-off-by: Lee Jones <lee.jones@...aro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org> --- drivers/usb/dwc3/dwc3-qcom.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 55ba04254e38..e4dac82abd7d 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -409,6 +409,9 @@ static int dwc3_qcom_clk_init(struct dwc3_qcom *qcom, int count) if (!np || !count) return 0; + if (count < 0) + return count; + qcom->num_clocks = count; qcom->clks = devm_kcalloc(dev, qcom->num_clocks, -- 2.17.1
Powered by blists - more mailing lists