linux-kernel - Re: [PATCH] clocksource/arm_arch_timer: extract elf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b3b2717-a639-3b1a-625f-5e7c1ff0ccd0@arm.com>
Date:   Mon, 10 Jun 2019 13:20:15 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Will Deacon <will.deacon@....com>,
        Andrew Murray <andrew.murray@....com>
Cc:     Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/arm_arch_timer: extract elf_hwcap use to
 arch-helper

On 10/06/2019 13:08, Will Deacon wrote:
> On Tue, Apr 30, 2019 at 02:14:13PM +0100, Andrew Murray wrote:
>> Different mechanisms are used to test and set elf_hwcaps between ARM
>> and ARM64, this results in the use of #ifdef's in this file when
>> setting/testing for the EVTSTRM hwcap.
>>
>> Let's improve readability by extracting this to an arch helper.
>>
>> Signed-off-by: Andrew Murray <andrew.murray@....com>
>> ---
>>  arch/arm/include/asm/arch_timer.h    | 13 +++++++++++++
>>  arch/arm64/include/asm/arch_timer.h  | 13 +++++++++++++
>>  drivers/clocksource/arm_arch_timer.c | 15 ++-------------
>>  3 files changed, 28 insertions(+), 13 deletions(-)
> 
> Acked-by: Will Deacon <will.deacon@....com>
> 
> I assume this is going via Marc Z.

More likely Daniel Lezcano. I'll ack the patch once reposted to take
Mark's remarks into account.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...