linux-kernel - Re: [PATCH 16/16] Staging: wlan-ng: cfg80211: fixed alignment issue with open parenthesis line ending with (

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190610154802.GA29035@kroah.com>
Date:   Mon, 10 Jun 2019 17:48:02 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Merwin Trever Ferrao <merwintf@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/16] Staging: wlan-ng: cfg80211: fixed alignment issue
 with open parenthesis line ending with (

On Mon, Jun 10, 2019 at 04:08:25PM +0530, Merwin Trever Ferrao wrote:
> From: Merwin Trever Ferrao <Merwintf@...il.com>
> 
> Fixed a coding style issue.
> 
> Signed-off-by: Merwin Trever Ferrao <merwintf@...il.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 32 ++++++++++++++----------------
>  1 file changed, 15 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index eee1998c4b18..5424e2682911 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -324,8 +324,7 @@ static int prism2_scan(struct wiphy *wiphy,
>  		(i < request->n_channels) && i < ARRAY_SIZE(prism2_channels);
>  		i++)
>  		msg1.channellist.data.data[i] =
> -			ieee80211_frequency_to_channel(
> -				request->channels[i]->center_freq);
> +			ieee80211_frequency_to_channel(request->channels[i]->center_freq);

And now you violate the other coding style rule of too long lines :(

You can just keep sending patches fixing this back and forth, if you
want a never-ending set of patches to be applied, but we don't really
like that.

So the code is ok as-is.

>  	msg1.channellist.data.len = request->n_channels;
>  
>  	msg1.maxchanneltime.data = 250;
> @@ -359,15 +358,15 @@ static int prism2_scan(struct wiphy *wiphy,
>  		freq = ieee80211_channel_to_frequency(msg2.dschannel.data,
>  						      NL80211_BAND_2GHZ);
>  		bss = cfg80211_inform_bss(wiphy,
> -			ieee80211_get_channel(wiphy, freq),
> -			CFG80211_BSS_FTYPE_UNKNOWN,
> -			(const u8 *)&msg2.bssid.data.data,
> -			msg2.timestamp.data, msg2.capinfo.data,
> -			msg2.beaconperiod.data,
> -			ie_buf,
> -			ie_len,
> -			(msg2.signal.data - 65536) * 100, /* Conversion to signed type */
> -			GFP_KERNEL
> +					  ieee80211_get_channel(wiphy, freq),
> +					  CFG80211_BSS_FTYPE_UNKNOWN,
> +					  (const u8 *)&msg2.bssid.data.data,
> +					  msg2.timestamp.data, msg2.capinfo.data,
> +					  msg2.beaconperiod.data,
> +					  ie_buf,
> +					  ie_len,
> +					  (msg2.signal.data - 65536) * 100, /* Conversion to signed type */
> +					  GFP_KERNEL
>  		);

Why is this final ); way over here?

>  
>  		if (!bss) {
> @@ -475,14 +474,13 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
>  			}
>  
>  			result = prism2_domibset_uint32(wlandev,
> -				DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
> -				sme->key_idx);
> +							DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
> +							sme->key_idx);
>  			if (result)
>  				goto exit;
>  
>  			/* send key to driver */
> -			did = didmib_dot11smt_wepdefaultkeystable_key(
> -					sme->key_idx + 1);
> +			did = didmib_dot11smt_wepdefaultkeystable_key(sme->key_idx + 1);

Too long of a line.

Remember, checkpatch is just a "hint", you still have to use your brain
when looking at the output of it.

thanks,

greg k-h