linux-kernel - Re: [PATCH] mei: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Jun 2019 20:34:29 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Tomas Winkler <tomas.winkler@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mei: no need to check return value of debugfs_create
 functions

On Tue, Jun 11, 2019 at 08:33:57PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Cc: Tomas Winkler <tomas.winkler@...el.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/misc/genwqe/card_base.c      |   5 -
>  drivers/misc/genwqe/card_base.h      |   2 +-
>  drivers/misc/genwqe/card_debugfs.c   | 165 +++++----------------------
>  drivers/misc/genwqe/card_dev.c       |   6 +-
>  drivers/misc/mei/debugfs.c           |  47 ++------
>  drivers/misc/mei/main.c              |   8 +-
>  drivers/misc/mei/mei_dev.h           |   7 +-
>  drivers/misc/mic/card/mic_debugfs.c  |  18 +--
>  drivers/misc/mic/cosm/cosm_debugfs.c |   4 -
>  drivers/misc/mic/host/mic_debugfs.c  |   4 -
>  drivers/misc/mic/scif/scif_debugfs.c |   5 -
>  drivers/misc/mic/vop/vop_debugfs.c   |   4 -
>  drivers/misc/ti-st/st_kim.c          |   4 -
>  drivers/misc/vmw_balloon.c           |  19 +--
>  14 files changed, 51 insertions(+), 247 deletions(-)

Ugh, nope, wrong patch, need to break this one up, sorry...

greg k-h