linux-kernel - Re: [PATCH] eeprom: idt_89hpesx: remove unneeded csr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Jun 2019 11:43:30 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Colin Ian King <colin.king@...onical.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eeprom: idt_89hpesx: remove unneeded csr_file variable

On Tue, Jun 11, 2019 at 08:17:00PM +0200, Greg Kroah-Hartman wrote:
> The csr_file variable was only ever set, never read.  So remove it from
> struct idt_89hpesx_dev as it is pointless to keep around.
> 
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Colin Ian King <colin.king@...onical.com>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  drivers/misc/eeprom/idt_89hpesx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index 8a4659518c33..81c70e5bc168 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -115,7 +115,6 @@ static struct dentry *csr_dbgdir;
>   * @client:	i2c client used to perform IO operations
>   *
>   * @ee_file:	EEPROM read/write sysfs-file
> - * @csr_file:	CSR read/write debugfs-node
>   */
>  struct idt_smb_seq;
>  struct idt_89hpesx_dev {
> @@ -137,7 +136,6 @@ struct idt_89hpesx_dev {
>  
>  	struct bin_attribute *ee_file;
>  	struct dentry *csr_dir;
> -	struct dentry *csr_file;
>  };
>  
>  /*
> @@ -1378,8 +1376,8 @@ static void idt_create_dbgfs_files(struct idt_89hpesx_dev *pdev)
>  	pdev->csr_dir = debugfs_create_dir(fname, csr_dbgdir);
>  
>  	/* Create Debugfs file for CSR read/write operations */
> -	pdev->csr_file = debugfs_create_file(cli->name, 0600,
> -		pdev->csr_dir, pdev, &csr_dbgfs_ops);
> +	debugfs_create_file(cli->name, 0600, pdev->csr_dir, pdev,
> +			    &csr_dbgfs_ops);
>  }
>  
>  /*
> -- 
> 2.22.0
> 

-- 
Kees Cook