lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Jun 2019 11:55:11 -0700 From: Kees Cook <keescook@...omium.org> To: "Gustavo A. R. Silva" <gustavo@...eddedor.com> Cc: Sathya Prakash <sathya.prakash@...adcom.com>, Chaitra P B <chaitra.basappa@...adcom.com>, Suganath Prabu Subramani <suganath-prabu.subramani@...adcom.com>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] scsi: mpt3sas: Mark expected switch fall-through On Tue, Jun 11, 2019 at 10:02:19AM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/scsi/mpt3sas/mpt3sas_base.c: In function ‘_base_update_ioc_page1_inlinewith_perf_mode’: > drivers/scsi/mpt3sas/mpt3sas_base.c:4510:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (ioc->high_iops_queues) { > ^ > drivers/scsi/mpt3sas/mpt3sas_base.c:4530:2: note: here > case MPT_PERF_MODE_LATENCY: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> Fixes: 30cb97023f38 ("scsi: mpt3sas: Introduce perf_mode module parameter") Reviewed-by: Kees Cook <keescook@...omium.org> -Kees > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > index e6377ec07f6c..9fefcd1e9c97 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -4527,6 +4527,7 @@ _base_update_ioc_page1_inlinewith_perf_mode(struct MPT3SAS_ADAPTER *ioc) > ioc_info(ioc, "performance mode: balanced\n"); > return; > } > + /* Fall through */ > case MPT_PERF_MODE_LATENCY: > /* > * Enable interrupt coalescing on all reply queues > -- > 2.21.0 > -- Kees Cook
Powered by blists - more mailing lists