linux-kernel - Re: [PATCH] vmw_ballon: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5A5203EB-A789-4C48-9C25-EF0C0CBCE5CD@vmware.com>
Date:   Tue, 11 Jun 2019 19:36:36 +0000
From:   Nadav Amit <namit@...are.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Julien Freche <jfreche@...are.com>,
        Pv-drivers <Pv-drivers@...are.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vmw_ballon: no need to check return value of
 debugfs_create functions

Please change the title of the patch to “vmw_balloon” (it is currently
“vmw_ballon”).

> On Jun 11, 2019, at 11:55 AM, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> 
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.

I remember I saw a discussion about it, and didn’t know the resolution.

If that's the decision (assuming debugfs initialization always succeeds),
and after fixing the title of the patch:

  Acked-by: Nadav Amit <namit@...are.com>

Thanks!
Nadav