linux-kernel - Re: [PATCH v3 2/2] power: supply: ucs1002: Add HWMON interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190611194651.rmyo4jhdy7xgrgpu@earth.universe>
Date:   Tue, 11 Jun 2019 21:46:51 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Andrey Smirnov <andrew.smirnov@...il.com>,
        "Andrew F. Davis" <afd@...com>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Chris Healy <cphealy@...il.com>,
        Cory Tusar <cory.tusar@....aero>,
        Lucas Stach <l.stach@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] power: supply: ucs1002: Add HWMON interface

Hi,

On Wed, Jun 05, 2019 at 11:39:45AM -0700, Guenter Roeck wrote:
> On Wed, Jun 05, 2019 at 10:47:25AM -0700, Andrey Smirnov wrote:
> > On Wed, Jun 5, 2019 at 9:26 AM Andrew F. Davis <afd@...com> wrote:
> > >
> > > On 6/5/19 3:23 AM, Andrey Smirnov wrote:
> > > > Expose current sensors found on UCS1002 via HWMON.
> > > >
> > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> > > > Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> > > > Cc: Chris Healy <cphealy@...il.com>
> > > > Cc: Cory Tusar <cory.tusar@....aero>
> > > > Cc: Lucas Stach <l.stach@...gutronix.de>
> > > > Cc: Fabio Estevam <fabio.estevam@....com>
> > > > Cc: Guenter Roeck <linux@...ck-us.net>
> > > > Cc: Sebastian Reichel <sre@...nel.org>
> > > > Cc: linux-kernel@...r.kernel.org
> > > > Cc: linux-pm@...r.kernel.org
> > > > ---
> > > >   drivers/power/supply/ucs1002_power.c | 6 ++++++
> > > >   1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/drivers/power/supply/ucs1002_power.c b/drivers/power/supply/ucs1002_power.c
> > > > index 677f20a4d76f..a4b6b37549cf 100644
> > > > --- a/drivers/power/supply/ucs1002_power.c
> > > > +++ b/drivers/power/supply/ucs1002_power.c
> > > > @@ -571,6 +571,12 @@ static int ucs1002_probe(struct i2c_client *client,
> > > >               return ret;
> > > >       }
> > > >
> > > > +     ret = devm_power_supply_add_hwmon_sysfs(info->charger);
> > >
> > > Could this be added to the core power supply framework on registering so
> > > all devices get this, vs each driver having to add this line?
> > >
> > 
> > I'd say it is up to Sebastian to decide if this should be opt-out
> > rather than opt-in. I have no objections to either approach.
> > 
> 
> Same here, and agreed.

I think this should be registered in power_supply_register() and
free'd in power_supply_unregister(). It's not device specific at
all and the functionality can be configured via Kconfig.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)