linux-kernel - Re: [PATCH net-next 1/4] net: dsa: do not check orig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Jun 2019 16:07:11 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vivien Didelot <vivien.didelot@...il.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>, andrew@...n.ch
Subject: Re: [PATCH net-next 1/4] net: dsa: do not check orig_dev in vlan del

On 6/11/19 2:47 PM, Vivien Didelot wrote:
> The current DSA code handling switchdev objects does not recurse into
> the lower devices thus is never called with an orig_dev member being
> a bridge device, hence remove this useless check.
> 
> At the same time, remove the comments about the callers, which is
> unlikely to be updated if the code changes and thus confusing.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian