linux-kernel - Re: [PATCH] perf script/intel-pt: set synth_opts.callchain for use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F8963F4B-46FF-41D2-B261-6DD2EE898D93@fb.com>
Date:   Tue, 11 Jun 2019 07:18:09 +0000
From:   Song Liu <songliubraving@...com>
To:     Adrian Hunter <adrian.hunter@...el.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>,
        David Carrillo Cisneros <davidca@...com>,
        Milian Wolff <milian.wolff@...b.com>,
        Jiri Olsa <jolsa@...nel.org>,
        "Arnaldo Carvalho de Melo" <acme@...hat.com>
Subject: Re: [PATCH] perf script/intel-pt: set synth_opts.callchain for
 use_browser > 0



> On Jun 10, 2019, at 11:45 PM, Adrian Hunter <adrian.hunter@...el.com> wrote:
> 
> On 11/06/19 2:42 AM, Song Liu wrote:
>> Currently, intel_pt_process_auxtrace_info() sets synth_opts.callchain for
>> use_browser != -1, which is not accurate after we set use_browser to 0 in
>> cmd_script(). As a result, the following commands sees a lot more errors
>> like:
>> 
>>  perf record -e intel_pt//u -C 10 -- sleep 3
>>  perf script
>> 
>>  ...
>>  instruction trace error type 1 time ...
>>  ...
>> 
>> This patch fixes this by checking use_browser > 0 instead.
>> 
>> Fixes: c1c9b9695cc8 ("perf script: Allow extended console debug output")
>> Reported-by: David Carrillo Cisneros <davidca@...com>
>> Cc: Milian Wolff <milian.wolff@...b.com>
>> Cc: Jiri Olsa <jolsa@...nel.org>
>> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
>> Cc: Adrian Hunter <adrian.hunter@...el.com>
>> Signed-off-by: Song Liu <songliubraving@...com>
>> ---
>> tools/perf/util/intel-pt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
>> index 6d288237887b..15692c104ca8 100644
>> --- a/tools/perf/util/intel-pt.c
>> +++ b/tools/perf/util/intel-pt.c
>> @@ -2588,7 +2588,7 @@ int intel_pt_process_auxtrace_info(union perf_event *event,
>> 	} else {
>> 		itrace_synth_opts__set_default(&pt->synth_opts,
>> 				session->itrace_synth_opts->default_no_sample);
>> -		if (use_browser != -1) {
>> +		if (use_browser > 0) {
> 
> That code has changed recently.  Refer:
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=26f19c2eb7e54

Thanks for a better fix! I was using Arnaldo's perf/urgent branch, and missed
this one. 

Song

> 
> 
>> 			pt->synth_opts.branches = false;
>> 			pt->synth_opts.callchain = true;
>> 		}