linux-kernel - Re: [PATCH -next] HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9510bce-525a-c4d4-531c-7cf55e141754@redhat.com>
Date:   Tue, 11 Jun 2019 10:39:07 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Yuehaibing <yuehaibing@...wei.com>, jikos@...nel.org,
        benjamin.tissoires@...hat.com, jkosina@...e.cz
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH -next] HID: logitech-dj: fix return value of
 logi_dj_recv_query_hidpp_devices

Hi,

On 11-06-19 05:00, Yuehaibing wrote:
> Hi all,
> 
> Friendly ping...
> 
> On 2019/5/25 22:09, YueHaibing wrote:
>> We should return 'retval' as the correct return value
>> instead of always zero.
>>
>> Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



>> ---
>>   drivers/hid/hid-logitech-dj.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
>> index 41baa4dbbfcc..7f8db602eec0 100644
>> --- a/drivers/hid/hid-logitech-dj.c
>> +++ b/drivers/hid/hid-logitech-dj.c
>> @@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev)
>>   				    HID_REQ_SET_REPORT);
>>   
>>   	kfree(hidpp_report);
>> -	return 0;
>> +	return retval;
>>   }
>>   
>>   static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev)
>>
>