linux-kernel - Re: [PATCH] mm: treewide: Clarify pgtable_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190611093822.GA26409@lakrids.cambridge.arm.com>
Date:   Tue, 11 Jun 2019 10:38:23 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Anshuman Khandual <anshuman.khandual@....com>,
        Matthew Wilcox <willy@...radead.org>,
        Michal Hocko <mhocko@...e.com>, Yu Zhao <yuzhao@...gle.com>,
        linux-mm@...ck.org, Mike Rapoport <rppt@...ux.ibm.com>
Subject: Re: [PATCH] mm: treewide: Clarify pgtable_page_{ctor,dtor}() naming

On Mon, Jun 10, 2019 at 01:05:11PM -0700, Andrew Morton wrote:
> On Mon, 10 Jun 2019 17:33:54 +0100 Mark Rutland <mark.rutland@....com> wrote:
> 
> > The naming of pgtable_page_{ctor,dtor}() seems to have confused a few
> > people, and until recently arm64 used these erroneously/pointlessly for
> > other levels of pagetable.
> > 
> > To make it incredibly clear that these only apply to the PTE level, and
> > to align with the naming of pgtable_pmd_page_{ctor,dtor}(), let's rename
> > them to pgtable_pte_page_{ctor,dtor}().
> > 
> > The bulk of this conversion was performed by the below Coccinelle
> > semantic patch, with manual whitespace fixups applied within macros, and
> > Documentation updated by hand.
> 
> eep.  I get a spectacular number of rejects thanks to Mike's series
> 
> asm-generic-x86-introduce-generic-pte_allocfree_one.patch
> alpha-switch-to-generic-version-of-pte-allocation.patch
> arm-switch-to-generic-version-of-pte-allocation.patch
> arm64-switch-to-generic-version-of-pte-allocation.patch
> csky-switch-to-generic-version-of-pte-allocation.patch
> m68k-sun3-switch-to-generic-version-of-pte-allocation.patch
> mips-switch-to-generic-version-of-pte-allocation.patch
> nds32-switch-to-generic-version-of-pte-allocation.patch
> nios2-switch-to-generic-version-of-pte-allocation.patch
> parisc-switch-to-generic-version-of-pte-allocation.patch
> riscv-switch-to-generic-version-of-pte-allocation.patch
> um-switch-to-generic-version-of-pte-allocation.patch
> unicore32-switch-to-generic-version-of-pte-allocation.patch
> 
> But at least they will make your patch smaller!

Aha; thanks for the heads-up!

Given this cleanup isn't urgent, I'll sit on it until the above has
settled.

Mark.