linux-kernel - Re: [PATCH v2 8/8] habanalabs: enable 64-bit DMA mask in POWER9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190611095857.GB24058@kroah.com>
Date:   Tue, 11 Jun 2019 11:58:57 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Oded Gabbay <oded.gabbay@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 8/8] habanalabs: enable 64-bit DMA mask in POWER9

On Tue, Jun 11, 2019 at 12:21:44PM +0300, Oded Gabbay wrote:
> +bool hl_pci_parent_is_phb4(struct hl_device *hdev)
> +{
> +	struct pci_dev *parent_port = hdev->pdev->bus->self;
> +
> +	if ((parent_port->vendor == PCI_VENDOR_ID_IBM) &&
> +			(parent_port->device == PCI_DEVICE_ID_IBM_PHB4)) {
> +		hdev->power9_64bit_dma_enable = 1;
> +		return true;
> +	}
> +
> +	hdev->power9_64bit_dma_enable = 0;
> +	return false;
> +}

That feels like a big hack.  ppc doesn't have any "what arch am I
running on?" runtime call?  Did you ask on the ppc64 mailing list?  I'm
ok to take this for now, but odds are you need a better fix for this
sometime...

thanks,

greg k-h