[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AM0PR04MB421171336B9206D02FF6514080ED0@AM0PR04MB4211.eurprd04.prod.outlook.com>
Date: Tue, 11 Jun 2019 10:00:36 +0000
From: Aisheng Dong <aisheng.dong@....com>
To: Linus Walleij <linus.walleij@...aro.org>,
Anson Huang <anson.huang@....com>,
Rob Herring <robh+dt@...nel.org>
CC: Fabio Estevam <festevam@...il.com>,
Shawn Guo <shawnguo@...nel.org>,
Stefan Agner <stefan@...er.ch>,
Sascha Hauer <kernel@...gutronix.de>,
Mark Rutland <mark.rutland@....com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
Maxime Ripard <maxime.ripard@...tlin.com>,
Olof Johansson <olof@...om.net>,
Simon Horman <horms+renesas@...ge.net.au>,
Jagan Teki <jagan@...rulasolutions.com>,
Leonard Crestez <leonard.crestez@....com>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Dinh Nguyen <dinguyen@...nel.org>,
Enric Balletbo i Serra <enric.balletbo@...labora.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN
> From: Linus Walleij [mailto:linus.walleij@...aro.org]
> Sent: Saturday, June 8, 2019 5:04 AM
>
> On Thu, May 30, 2019 at 5:04 AM <Anson.Huang@....com> wrote:
>
> > From: Anson Huang <Anson.Huang@....com>
> >
> > Add binding doc for i.MX8MN pinctrl driver.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
>
> Looks mostly OK to me, but I'd like the maintainers to review, so Dong et al
> please look at this!
>
> > +Required properties:
> > +- compatible: "fsl,imx8mn-iomuxc"
>
> So should this not be "nxp,imx8mn-iomuxc"
> or "nxp,freescale-imx8mn-iomuxc" or something these days? The vendor name
> is nxp is it not.
>
> I was complaining to the DT maintainers at one point that these companies
> seem to buy each other left and right so this vendor nomenclature is dubious,
> but I guess at least it should reflect the vendor that produced the chip or
> something.
>
> If everyone is happy with "fsl,*" I will not complain though.
> (i.e. if the maintainers ACK it.)
We preferred to keep "fsl,*" for Freescale i.MX product line according to last discussion.
And we already did this way for most i.MX devices.
So:
Acked-by: Dong Aisheng <aisheng.dong@....com>
(Rob, please let us know if you have different idea)
Regards
Dong Aisheng
>
> Yours,
> Linus Walleij
Powered by blists - more mailing lists