lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Jun 2019 15:11:48 +0200 From: Arnd Bergmann <arnd@...db.de> To: Tomer Maimon <tmaimon77@...il.com> Cc: Olof Johansson <olof@...om.net>, gregkh <gregkh@...uxfoundation.org>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Avi Fishman <avifishman70@...il.com>, Patrick Venture <venture@...gle.com>, Nancy Yuen <yuenn@...gle.com>, benjaminfair@...gle.com, Joel Stanley <joel@....id.au>, DTML <devicetree@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, OpenBMC Maillist <openbmc@...ts.ozlabs.org>, Andrew Jeffery <andrew@...id.au>, linux-aspeed@...ts.ozlabs.org Subject: Re: [PATCH v1 2/2] soc: nuvoton: add NPCM LPC BPC driver On Mon, Jun 10, 2019 at 4:19 PM Tomer Maimon <tmaimon77@...il.com> wrote: > > Add Nuvoton BMC NPCM BIOS post code (BPC) driver. > > The NPCM BPC monitoring two I/O address written by > the host on the Low Pin Count (LPC) bus, the capure > data stored in 128-word FIFO. > > Signed-off-by: Tomer Maimon <tmaimon77@...il.com> We've run into this situation before, but don't have a good solution yet: The driver seems useful and well implemented, but I keep having a bad feeling about adding a chardev driver into drivers/soc for something that is clearly specific to a particular implementation on the hardware side but generic on the user interface. The same user interface might be used on an Aspeed BMC or any other one, so please coordinate at least between Novoton and Aspeed developers on creating a common user interface, and review each other's patches. Maybe we can introduce a drivers/bmc/ (or even drivers/openbmc) that collects all those user interfaces with a thin abstraction layer and one or two hardware specific back-ends? Arnd
Powered by blists - more mailing lists