lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e90e7ab1-1c30-de1f-80de-5b86f99cb78b@arm.com>
Date:   Tue, 11 Jun 2019 14:28:15 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Julien Thierry <julien.thierry@....com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, rostedt@...dmis.org,
        yuzenghui@...wei.com, wanghaibin.wang@...wei.com,
        james.morse@....com, will.deacon@....com, catalin.marinas@....com,
        mark.rutland@....com, liwei391@...wei.com
Subject: Re: [PATCH v4 0/8] arm64: IRQ priority masking and Pseudo-NMI fixes

Hi Julien,

On 11/06/2019 10:38, Julien Thierry wrote:
> Hi,
> 
> Version one[1] of this series attempted to fix the issue reported by
> Zenghui[2] when using the function_graph tracer with IRQ priority
> masking.
> 
> Since then, I realized that priority masking and the use of Pseudo-NMIs
> was more broken than I thought.
> 
> * Patch 1-2 are just some cleanup
> * Patch 3 fixes a potential issue with not clobbering condition flags
>   in irqflags operations
> * Patch 4 fixes an issue where calling C code in Pseudo-NMI before
>   entering NMI enter could lead to potential races
> * Patch 5 fixes the function_graph issue when using priority masking
> * Patch 6 introduces some debug to hopefully avoid breaking things in
>   the future
> * Patch 7 is a rebased version of the patch sent by Wei Li[3] fixing
>   an error that can happen during on some platform using the priority
>   masking feature
> * Patch 8 re-enables the Pseudo-NMI selection
> 
> Changes since V3 [4]:
> - Rebase on v5.2-rc4
> - Fix comments/typos/missed updates
> - Use single condition evalution for nmi_enter and nmi_exit

Thanks for following up on this. For the whole series:

Reviewed-by: Marc Zyngier <marc.zyngier@....com>

	M.
-- 
Jazz is not dead. It just smells funny...

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ