linux-kernel - Re: [PATCH v3] riscv: Fix udelay in RV32.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.1906110729030.16050@viisi.sifive.com>
Date:   Tue, 11 Jun 2019 07:29:10 -0700 (PDT)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     Nick Hu <nickhu@...estech.com>
cc:     greentime@...estech.com, palmer@...ive.com, albert@...ive.com,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        hch@...radead.org, green.hu@...il.com
Subject: Re: [PATCH v3] riscv: Fix udelay in RV32.

On Thu, 30 May 2019, Nick Hu wrote:

> In RV32, udelay would delay the wrong cycle. When it shifts right
> "UDELAY_SHITFT" bits, it either delays 0 cycle or 1 cycle. It only works
> correctly in RV64. Because the 'ucycles' always needs to be 64 bits
> variable.
> 
> Signed-off-by: Nick Hu <nickhu@...estech.com>
> Reviewed-by: Palmer Dabbelt <palmer@...ive.com>

Thanks, queued for v5.2-rc.


- Paul