linux-kernel - Re: [PATCH 06/10] mfd / platform: cros_ec: Reorganize platform and mfd includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190611171030.GC143729@dtor-ws>
Date:   Tue, 11 Jun 2019 10:10:30 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel@...r.kernel.org, gwendal@...omium.org,
        Guenter Roeck <groeck@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Lee Jones <lee.jones@...aro.org>, kernel@...labora.com,
        dtor@...omium.org, Mauro Carvalho Chehab <mchehab@...nel.org>,
        alsa-devel@...a-project.org,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-iio@...r.kernel.org,
        Fabien Lahoudere <fabien.lahoudere@...labora.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-i2c@...r.kernel.org, linux-rtc@...r.kernel.org,
        Heiko Stuebner <heiko@...ech.de>,
        Brian Norris <briannorris@...omium.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Sebastian Reichel <sre@...nel.org>,
        Rushikesh S Kadam <rushikesh.s.kadam@...el.com>,
        linux-input@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
        Jonathan Cameron <jic23@...nel.org>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-media@...r.kernel.org, linux-pwm@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Ravi Chandra Sadineni <ravisadineni@...omium.org>,
        linux-pm@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Evan Green <evgreen@...omium.org>,
        Hartmut Knaack <knaack.h@....de>,
        Cheng-Yi Chiang <cychiang@...omium.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Kees Cook <keescook@...omium.org>,
        Colin Ian King <colin.king@...onical.com>,
        Mark Brown <broonie@...nel.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH 06/10] mfd / platform: cros_ec: Reorganize platform and
 mfd includes

On Tue, Jun 04, 2019 at 05:20:15PM +0200, Enric Balletbo i Serra wrote:
> There is a bit of mess between cros-ec mfd includes and platform
> includes. For example, we have a linux/mfd/cros_ec.h include that
> exports the interface implemented in platform/chrome/cros_ec_proto.c. Or
> we have a linux/mfd/cros_ec_commands.h file that is non related to the
> multifunction device (in the sense that is not exporting any function of
> the mfd device). This causes crossed includes between mfd and
> platform/chrome subsystems and makes the code difficult to read, apart
> from creating 'curious' situations where a platform/chrome driver includes
> a linux/mfd/cros_ec.h file just to get the exported functions that are
> implemented in another platform/chrome driver.
> 
> In order to have a better separation on what the cros-ec multifunction
> driver does and what the cros-ec core provides move and rework the
> affected includes doing:
> 
>  - Move cros_ec_commands.h to include/linux/platform_data/cros_ec_commands.h
>  - Get rid of the parts that are implemented in the platform/chrome/cros_ec_proto.c
>    driver from include/linux/mfd/cros_ec.h to a new file
>    include/linux/platform_data/cros_ec_proto.h
>  - Update all the drivers with the new includes, so
>    - Drivers that only need to know about the protocol include
>      - linux/platform_data/cros_ec_proto.h
>      - linux/platform_data/cros_ec_commands.h
>    - Drivers that need to know about the cros-ec mfd device also include
>      - linux/mfd/cros_ec.h
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com> # for input

Thanks.

-- 
Dmitry