linux-kernel - Re: [PATCH net v2] net: ethtool: Allow matching on vlan DEI bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190612.101033.1275036348342275988.davem@davemloft.net>
Date:   Wed, 12 Jun 2019 10:10:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     maxime.chevallier@...tlin.com
Cc:     pablo@...filter.org, f.fainelli@...il.com, jiri@...lanox.com,
        jakub.kicinski@...ronome.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, antoine.tenart@...tlin.com,
        thomas.petazzoni@...tlin.com, mirq-linux@...e.qmqm.pl,
        toshiaki.makita1@...il.com
Subject: Re: [PATCH net v2] net: ethtool: Allow matching on vlan DEI bit

From: Maxime Chevallier <maxime.chevallier@...tlin.com>
Date: Wed, 12 Jun 2019 17:18:38 +0200

> Using ethtool, users can specify a classification action matching on the
> full vlan tag, which includes the DEI bit (also previously called CFI).
> 
> However, when converting the ethool_flow_spec to a flow_rule, we use
> dissector keys to represent the matching patterns.
> 
> Since the vlan dissector key doesn't include the DEI bit, this
> information was silently discarded when translating the ethtool
> flow spec in to a flow_rule.
> 
> This commit adds the DEI bit into the vlan dissector key, and allows
> propagating the information to the driver when parsing the ethtool flow
> spec.
> 
> Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator")
> Reported-by: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> ---
> V1 -> V2: Use "DEI" instead of the old name "CFI", as suggested by Toshiaki.
>           Perform endianness swap on the constant, sothat it's done at
> 	  build-time, as suggested by Jakub.

Applied and queued up for -stable, thanks.