linux-kernel - Re: [PATCH 1/1] ARM: dts: imx6ul: Add PXP node

Open Source and information security mailing list archives

Message-ID: <20190612172103.gat3yrub2iyurai5@pengutronix.de>
Date:   Wed, 12 Jun 2019 19:21:03 +0200
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Sébastien Szymanski 
        <sebastien.szymanski@...adeus.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, NXP Linux Team <linux-imx@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH 1/1] ARM: dts: imx6ul: Add PXP node

Hi Sébastien,

On 19-06-06 18:46, Sébastien Szymanski wrote:
> Add PXP node for i.MX6UL/L SoC.
> 
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@...adeus.com>
> ---
>  arch/arm/boot/dts/imx6ul.dtsi  | 9 +++++++++
>  arch/arm/boot/dts/imx6ull.dtsi | 6 ++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index f10012de5eb6..a3c005373ae1 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -971,6 +971,15 @@
>  				status = "disabled";
>  			};
>  
> +			pxp: pxp@...c000 {
> +				compatible = "fsl,imx6ul-pxp";
> +				reg = <0x021cc000 0x4000>;
> +				interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX6UL_CLK_PXP>;
> +				clock-names = "axi";
> +				status = "disabled";

Can you drop the status line because its a platform device and isn't
removeable.

> +			};
> +
>  			qspi: spi@...0000 {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
> diff --git a/arch/arm/boot/dts/imx6ull.dtsi b/arch/arm/boot/dts/imx6ull.dtsi
> index 22e4a307fa59..b017e925bd87 100644
> --- a/arch/arm/boot/dts/imx6ull.dtsi
> +++ b/arch/arm/boot/dts/imx6ull.dtsi
> @@ -34,6 +34,12 @@
>  	compatible = "fsl,imx6ull-ocotp", "syscon";
>  };
>  
> +&pxp {
> +	compatible = "fsl,imx6ull-pxp";
> +	interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
> +		     <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> +};
> +
>  &usdhc1 {
>  	compatible = "fsl,imx6ull-usdhc", "fsl,imx6sx-usdhc";
>  };
> -- 
> 2.19.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives