linux-kernel - Re: [PATCH 4/4] mm: shrinker: make shrinker not depend on memcg kmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8f6f119-fd72-9a93-de99-fc7bea6404c0@linux.alibaba.com>
Date:   Tue, 11 Jun 2019 22:07:54 -0700
From:   Yang Shi <yang.shi@...ux.alibaba.com>
To:     "Kirill A. Shutemov" <kirill@...temov.name>
Cc:     ktkhai@...tuozzo.com, kirill.shutemov@...ux.intel.com,
        hannes@...xchg.org, mhocko@...e.com, hughd@...gle.com,
        shakeelb@...gle.com, rientjes@...gle.com,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] mm: shrinker: make shrinker not depend on memcg kmem



On 6/11/19 7:52 PM, Kirill A. Shutemov wrote:
> On Fri, Jun 07, 2019 at 02:07:39PM +0800, Yang Shi wrote:
>> Currently shrinker is just allocated and can work when memcg kmem is
>> enabled.  But, THP deferred split shrinker is not slab shrinker, it
>> doesn't make too much sense to have such shrinker depend on memcg kmem.
>> It should be able to reclaim THP even though memcg kmem is disabled.
>>
>> Introduce a new shrinker flag, SHRINKER_NONSLAB, for non-slab shrinker,
>> i.e. THP deferred split shrinker.  When memcg kmem is disabled, just
>> such shrinkers can be called in shrinking memcg slab.
> Looks like it breaks bisectability. It has to be done before makeing
> shrinker memcg-aware, hasn't it?

No, it doesn't break bisectability. But, THP shrinker just can be called 
with kmem charge enabled without this patch.

>