linux-kernel - Re: [PATCH-next 13/20] gpio: gpio-omap: simplify omap_toggle_gpio_edge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZmnezPYiKpi+7Ka70YL4H4O=_Gv=DqXfvY9J4xv8X37Q@mail.gmail.com>
Date:   Wed, 12 Jun 2019 10:54:10 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     Russell King <rmk@....linux.org.uk>,
        Tony Lindgren <tony@...mide.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH-next 13/20] gpio: gpio-omap: simplify omap_toggle_gpio_edge_triggering()

On Mon, Jun 10, 2019 at 7:12 PM Grygorii Strashko
<grygorii.strashko@...com> wrote:

> From: Russell King <rmk+kernel@...linux.org.uk>
>
> This function open-codes an exclusive-or bitwise operation using an
> if() statement and explicitly setting or clearing the bit. Instead,
> use an exclusive-or operation instead, and simplify the function.
>
> We can combine the preprocessor conditional using IS_ENABLED() and
> gain some additional compilation coverage.
>
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>

Patch applied.

Yours,
Linus Walleij