linux-kernel - Re: [PATCH 03/13] driver_find_device: Unify the match function with class_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <136ab9e5-694a-c277-5125-070df60453e3@arm.com>
Date:   Wed, 12 Jun 2019 10:36:29 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        rafael@...nel.org, minyard@....org, linux@...linux.org.uk,
        thierry.reding@...il.com, will.deacon@....com, joro@...tes.org,
        oberpar@...ux.ibm.com, sebott@...ux.ibm.com, airlied@...ux.ie,
        daniel@...ll.ch, nehal-bakulchandra.shah@....com,
        shyam-sundar.s-k@....com, borntraeger@...ibm.com
Subject: Re: [PATCH 03/13] driver_find_device: Unify the match function with
 class_find_device()

Hi Lee,

On 12/06/2019 10:32, Lee Jones wrote:
> On Wed, 05 Jun 2019, Suzuki K Poulose wrote:
> 
>> The driver_find_device() accepts a match function pointer to
>> filter the devices for lookup, similar to bus/class_find_device().
>> However, there is a minor difference in the prototype for the
>> match parameter for driver_find_device() with the now unified
>> version accepted by {bus/class}_find_device(), where it doesn't
>> accept a "const" qualifier for the data argument. This prevents
>> us from reusing the generic match functions for driver_find_device().
>>
>> For this reason, change the prototype of the driver_find_device() to
>> make the "match" parameter in line with {bus/class}_find_device()
>> and adjust its callers to use the const qualifier. Also, we could
>> now promote the "data" parameter to const as we pass it down
>> as a const parameter to the match functions.
>>
>> Cc: Corey Minyard <minyard@....org>
>> Cc: Russell King <linux@...linux.org.uk>
>> Cc: Thierry Reding <thierry.reding@...il.com>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
>> Cc: Will Deacon <will.deacon@....com>
>> Cc: Joerg Roedel <joro@...tes.org>
>> Cc: Peter Oberparleiter <oberpar@...ux.ibm.com>
>> Cc: Sebastian Ott <sebott@...ux.ibm.com>
>> Cc: David Airlie <airlied@...ux.ie>
>> Cc: Daniel Vetter <daniel@...ll.ch>
>> Cc: Nehal Shah <nehal-bakulchandra.shah@....com>
>> Cc: Shyam Sundar S K <shyam-sundar.s-k@....com>
>> Cc: Lee Jones <lee.jones@...aro.org>
>> Cc: Christian Borntraeger <borntraeger@...ibm.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>


>>   drivers/mfd/altera-sysmgr.c          | 4 ++--
>>   drivers/mfd/syscon.c                 | 2 +-
> 
> I'm okay with the changes.  How do you plan on managing the merge?

Thanks for looking the changes.

I assume, Greg can pull this once we have got the Acks.
Btw, would you mind providing the necessary tags here if you are OK with it ?


Cheers
Suzuki