lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Jun 2019 13:11:46 +0200 From: Arend Van Spriel <arend.vanspriel@...adcom.com> To: Ulf Hansson <ulf.hansson@...aro.org>, Doug Anderson <dianders@...omium.org> Cc: "Hunter, Adrian" <adrian.hunter@...el.com>, Kalle Valo <kvalo@...eaurora.org>, "brcm80211-dev-list.pdl@...adcom.com" <brcm80211-dev-list.pdl@...adcom.com>, "linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>, Double Lo <double.lo@...ress.com>, "briannorris@...omium.org" <briannorris@...omium.org>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, Naveen Gupta <naveen.gupta@...ress.com>, Madhan Mohan R <madhanmohan.r@...ress.com>, "mka@...omium.org" <mka@...omium.org>, Wright Feng <wright.feng@...ress.com>, Chi-Hsien Lin <chi-hsien.lin@...ress.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "brcm80211-dev-list@...ress.com" <brcm80211-dev-list@...ress.com>, Franky Lin <franky.lin@...adcom.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Hante Meuleman <hante.meuleman@...adcom.com>, YueHaibing <yuehaibing@...wei.com>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail On 6/12/2019 12:10 PM, Ulf Hansson wrote: >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: >> mmc_set_data_timeout(md, func->card); >> mmc_wait_for_req(func->card->host, mr); > These are not okay, none of these things calls should really be done > from an SDIO func driver. > > It tells me that the func driver is a doing workaround for something > that should be managed in a common way. We are using some low-level functions passing chain of skbuff to the device using CMD53 with scatterlist. If I recall correctly Marvell made an attempt to have a similar function for it in the mmc stack. Not sure if that ever made it in. If so I can rework our driver using that API. If not, I can make a new attempt. Regards, Arend
Powered by blists - more mailing lists