linux-kernel - Re: [PATCH v2] sched/core: add __sched tag for io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c77fa8f-b93a-c4d6-f946-c3867a18af27@huawei.com>
Date:   Wed, 12 Jun 2019 19:34:01 +0800
From:   Gao Xiang <gaoxiang25@...wei.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     LKML <linux-kernel@...r.kernel.org>, Tejun Heo <tj@...nel.org>,
        "Ingo Molnar" <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        <stable@...r.kernel.org>, Miao Xie <miaoxie@...wei.com>,
        <koujilong@...wei.com>
Subject: Re: [PATCH v2] sched/core: add __sched tag for io_schedule()

Friendly ping...

Thanks,
Gao Xiang

On 2019/6/3 17:13, Gao Xiang wrote:
> non-inline io_schedule() was introduced in
> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
> Keep in line with io_schedule_timeout, Otherwise
> "/proc/<pid>/wchan" will report io_schedule()
> rather than its callers when waiting io.
> 
> Reported-by: Jilong Kou <koujilong@...wei.com>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Acked-by: Tejun Heo <tj@...nel.org>
> Fixes: 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
> Cc: <stable@...r.kernel.org> # 4.11+
> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
> ---
> change log v2:
>  - add missing tags
> 
>  kernel/sched/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 874c427742a9..4d5962232a55 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -5123,7 +5123,7 @@ long __sched io_schedule_timeout(long timeout)
>  }
>  EXPORT_SYMBOL(io_schedule_timeout);
>  
> -void io_schedule(void)
> +void __sched io_schedule(void)
>  {
>  	int token;
>  
>