linux-kernel - Re: [PATCH v2 8/8] habanalabs: enable 64-bit DMA mask in POWER9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOSf1CF=gkGDVbiqT2NM1Rd_-aWKePA9D1hyj4FwY+M+4gPRBQ@mail.gmail.com>
Date:   Wed, 12 Jun 2019 21:48:12 +1000
From:   "Oliver O'Halloran" <oohall@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Oded Gabbay <oded.gabbay@...il.com>,
        Greg KH <gregkh@...uxfoundation.org>, linuxppc-dev@...abs.org,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Alexey Kardashevskiy <aik@...abs.ru>
Subject: Re: [PATCH v2 8/8] habanalabs: enable 64-bit DMA mask in POWER9

On Wed, Jun 12, 2019 at 4:53 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Wed, Jun 12, 2019 at 04:35:22PM +1000, Oliver O'Halloran wrote:
> > Setting a 48 bit DMA mask doesn't work today because we only allocate
> > IOMMU tables to cover the 0..2GB range of PCI bus addresses.
>
> I don't think that is true upstream, and if it is we need to fix bug
> in the powerpc code.  powerpc should be falling back treating a 48-bit
> dma mask like a 32-bit one at least, that is use dynamic iommu mappings
> instead of using the direct mapping.  And from my reding of
> arch/powerpc/kernel/dma-iommu.c that is exactly what it does.

This is more or less what Alexey's patches fix. The IOMMU table
allocated for the 32bit DMA window is only sized for 2GB in the
platform code, see pnv_pci_ioda2_setup_default_config().