linux-kernel - Re: [Qemu-devel] [PATCH v12 4/7] dm: enable synchronous dax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <332155967.34508010.1560306189624.JavaMail.zimbra@redhat.com>
Date:   Tue, 11 Jun 2019 22:23:09 -0400 (EDT)
From:   Pankaj Gupta <pagupta@...hat.com>
To:     Mike Snitzer <snitzer@...hat.com>
Cc:     cohuck@...hat.com, jack@...e.cz, kvm@...r.kernel.org,
        mst@...hat.com, jasowang@...hat.com, david@...morbit.com,
        qemu-devel@...gnu.org, virtualization@...ts.linux-foundation.org,
        dm-devel@...hat.com, adilger kernel <adilger.kernel@...ger.ca>,
        zwisler@...nel.org, aarcange@...hat.com,
        dave jiang <dave.jiang@...el.com>, jstaron@...gle.com,
        linux-nvdimm@...ts.01.org,
        vishal l verma <vishal.l.verma@...el.com>, david@...hat.com,
        willy@...radead.org, hch@...radead.org, linux-acpi@...r.kernel.org,
        jmoyer@...hat.com, linux-ext4@...r.kernel.org, lenb@...nel.org,
        kilobyte@...band.pl, rdunlap@...radead.org, riel@...riel.com,
        yuval shaia <yuval.shaia@...cle.com>, stefanha@...hat.com,
        pbonzini@...hat.com, dan j williams <dan.j.williams@...el.com>,
        lcapitulino@...hat.com, kwolf@...hat.com, nilal@...hat.com,
        tytso@....edu, xiaoguangrong eric <xiaoguangrong.eric@...il.com>,
        darrick wong <darrick.wong@...cle.com>, rjw@...ysocki.net,
        linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, imammedo@...hat.com
Subject: Re: [Qemu-devel] [PATCH v12 4/7] dm: enable synchronous dax


> On Tue, Jun 11 2019 at 12:37pm -0400,
> Pankaj Gupta <pagupta@...hat.com> wrote:
> 
> > This patch sets dax device 'DAXDEV_SYNC' flag if all the target
> > devices of device mapper support synchrononous DAX. If device
> > mapper consists of both synchronous and asynchronous dax devices,
> > we don't set 'DAXDEV_SYNC' flag.
> > 
> > 'dm_table_supports_dax' is refactored to pass 'iterate_devices_fn'
> > as argument so that the callers can pass the appropriate functions.
> > 
> > Suggested-by: Mike Snitzer <snitzer@...hat.com>
> > Signed-off-by: Pankaj Gupta <pagupta@...hat.com>
> 
> Thanks, and for the benefit of others, passing function pointers like
> this is perfectly fine IMHO because this code is _not_ in the fast
> path.  These methods are only for device creation.
> 
> Reviewed-by: Mike Snitzer <snitzer@...hat.com>

Thank you, Mike

Best regards,
Pankaj

> 
>