linux-kernel - Re: [PATCH v5 2/3] HID: quirks: Refactor ELAN 400 and 401 handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1906121644160.27227@cbobk.fhfr.pm>
Date:   Wed, 12 Jun 2019 16:45:11 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
cc:     Jeffrey Hugo <jeffrey.l.hugo@...il.com>,
        benjamin.tissoires@...hat.com, bjorn.andersson@...aro.org,
        lee.jones@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
        agross@...nel.org, david.brown@...aro.org, hdegoede@...hat.com,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/3] HID: quirks: Refactor ELAN 400 and 401 handling

On Tue, 11 Jun 2019, Dmitry Torokhov wrote:

> > +static const char *hid_elan_i2c_ignore[] = {
> 
> If this is a copy of elan whitelist, then, if we do not want to bother
> with sharing it in object form (as a elan-i2c-ids module), can we at
> least move it into include/linux/input/elan-i2c-ids.h and consume from
> hid-quirks.c?

Let's just not duplicate it in both objects. Why not properly export it 
from hid_quirks?

Thanks,

-- 
Jiri Kosina
SUSE Labs