linux-kernel - Re: [Patch v2] x86/cpu: Add Ice Lake NNPI to Intel family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73eb1ba5-dc29-53ee-487d-d22700b874a1@intel.com>
Date:   Wed, 12 Jun 2019 07:51:26 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org, bp@...e.de,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        platform-driver-x86@...r.kernel.org,
        Qiuxu Zhuo <qiuxu.zhuo@...el.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Len Brown <lenb@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [Patch v2] x86/cpu: Add Ice Lake NNPI to Intel family

On 6/12/19 2:52 AM, Andy Shevchenko wrote:
>>  #define INTEL_FAM6_ICELAKE_MOBILE	0x7E
>> +#define INTEL_FAM6_ICELAKE_NNPI		0x9D
> What "I" stands for?
> 
> For me sounds like it's redundant here or something like NNP_DLI would be
> better (because somewhere we have _NP as for Network Processor).

Let's not bikeshed this too much.  These things aren't used that widely
and mostly they're just used for figuring out the processor generation.
 It's exceedingly rare to have something like:


	if (model == INTEL_FAM6_ICELAKE_MOBILE)
		foo();
	else if (model == INTEL_FAM6_ICELAKE_NNPI)
		bar();

where what you suggest would matter.

Preserving the ability to google "ice lake nnpi" is pretty important, so
preserving the Intel name makes a lot of sense here when possible.

Do we *HAVE* an Ice Lake network processor?