linux-kernel - Re: [PATCH][next] leds: lm36274: remove redundant initialization of variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5D0117D0.501@bfs.de>
Date:   Wed, 12 Jun 2019 17:18:40 +0200
From:   walter harms <wharms@....de>
To:     Colin King <colin.king@...onical.com>
CC:     Dan Murphy <dmurphy@...com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH][next] leds: lm36274: remove redundant initialization
 of variable ret



Am 12.06.2019 16:56, schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable ret is being initialized with a value that is never
> read, hence it is redundant and can be removed.  Also move the
> declaration of ret to the for loop scope.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/leds/leds-lm36274.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c
> index ed9dc857ec8f..b55bd238c074 100644
> --- a/drivers/leds/leds-lm36274.c
> +++ b/drivers/leds/leds-lm36274.c
> @@ -74,7 +74,6 @@ static int lm36274_parse_dt(struct lm36274 *lm36274_data)
>  	struct device *dev = &lm36274_data->pdev->dev;
>  	const char *name;
>  	int child_cnt;
> -	int ret = -EINVAL;
>  
>  	/* There should only be 1 node */
>  	child_cnt = device_get_child_node_count(dev);
> @@ -82,6 +81,8 @@ static int lm36274_parse_dt(struct lm36274 *lm36274_data)
>  		return -EINVAL;
>  
>  	device_for_each_child_node(dev, child) {
> +		int ret;
> +
>  		ret = fwnode_property_read_string(child, "label", &name);
>  		if (ret)
>  			snprintf(label, sizeof(label),

this looks odd,
i would leave ret in place or move char *name also.

just my 2 cents,

re,
 wh