linux-kernel - Re: [PATCH net v2] tcp: avoid creating multiple req socks with the same tuples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d3d6b84-acaa-b98a-8454-96546fbe012d@huawei.com>
Date:   Thu, 13 Jun 2019 14:34:37 +0800
From:   maowenan <maowenan@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <edumazet@...gle.com>
Subject: Re: [PATCH net v2] tcp: avoid creating multiple req socks with the
 same tuples



On 2019/6/13 0:25, David Miller wrote:
> From: Mao Wenan <maowenan@...wei.com>
> Date: Wed, 12 Jun 2019 11:57:15 +0800
> 
>> diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c
>> index c4503073248b..b6a1b5334565 100644
>> --- a/net/ipv4/inet_hashtables.c
>> +++ b/net/ipv4/inet_hashtables.c
>> @@ -477,6 +477,7 @@ bool inet_ehash_insert(struct sock *sk, struct sock *osk)
>>  	struct inet_ehash_bucket *head;
>>  	spinlock_t *lock;
>>  	bool ret = true;
>> +	struct sock *reqsk = NULL;
> 
> Please preserve the reverse christmas tree local variable ordering here.

ok, thanks.
> 
> Thank you.
> 
> .
>