linux-kernel - Re: [PATCH] crypto: user - fix potential warnings in cryptouser.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190613060149.a66vdfyrxe356nr2@gondor.apana.org.au>
Date:   Thu, 13 Jun 2019 14:01:49 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-crypto@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>,
        Corentin Labbe <clabbe@...libre.com>
Subject: Re: [PATCH] crypto: user - fix potential warnings in cryptouser.h

On Sun, Jun 09, 2019 at 03:57:10PM +0900, Masahiro Yamada wrote:
>
> diff --git a/include/crypto/internal/cryptouser.h b/include/crypto/internal/cryptouser.h
> index 8c602b187c58..2339cb06dbf8 100644
> --- a/include/crypto/internal/cryptouser.h
> +++ b/include/crypto/internal/cryptouser.h
> @@ -3,12 +3,15 @@
>  
>  extern struct sock *crypto_nlsk;
>  
> +struct crypto_user_alg;

Please change this to instead include <linux/cryptouser.h>.

In the crypto API the internal header file should always include the
external header file.

You can also remove the inclusion of the external header file from
the users of crypto/internal/cryptouser.h.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt