linux-kernel - Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190613031355.7vya4vwhr3eia5g4@gondor.apana.org.au>
Date:   Thu, 13 Jun 2019 11:13:55 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Heiko Carstens <heiko.carstens@...ibm.com>
Cc:     David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-crypto@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Cornelia Huck <cohuck@...hat.com>
Subject: Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP

On Wed, Jun 12, 2019 at 05:08:50PM +0200, Heiko Carstens wrote:
> On Wed, Jun 12, 2019 at 03:33:02PM +0200, David Hildenbrand wrote:
> > s390x crypto is one of the rare modules that returns -EOPNOTSUPP instead of
> > -ENODEV in case HW support is not available.
> > 
> > Convert to -ENODEV, so e.g., systemd's systemd-modules-load.service
> > ignores this error properly.
> > 
> > v2 -> v3:
> > - "s390/pkey: Use -ENODEV instead of -EOPNOTSUPP"
> > -- Also convert pkey_clr2protkey() as requested by Harald
> > - Add r-b's (thanks!)
> > 
> > v1 -> v2:
> > - Include
> > -- "s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP"
> > -- "s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP"
> > -- "s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP"
> > 
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> > Cc: Vasily Gorbik <gor@...ux.ibm.com>
> > Cc: Christian Borntraeger <borntraeger@...ibm.com>
> > Cc: Harald Freudenberger <freude@...ux.ibm.com>
> > Cc: Cornelia Huck <cohuck@...hat.com>
> > 
> > David Hildenbrand (4):
> >   s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
> >   s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP
> >   s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP
> >   s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP
> 
> Should I pick these up so they can go upstream via the s390 tree?

Sure Heiko.  Thanks!
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt