linux-kernel - Re: [PATCH net-next v2 1/2] hinic: add rss support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Jun 2019 15:46:37 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Xue Chaojing <xuechaojing@...wei.com>
Cc:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <luoshaokai@...wei.com>,
        <cloud.wangxiaoyun@...wei.com>, <chiqijun@...wei.com>,
        <wulike1@...wei.com>
Subject: Re: [PATCH net-next v2 1/2] hinic: add rss support

On Tue, 11 Jun 2019 18:12:33 +0000, Xue Chaojing wrote:
> +	for (i = 0; i < HINIC_RSS_INDIR_SIZE; i++)
> +		indir_tbl[i] = (i / HINIC_RSS_INDIR_SIZE) * nic_dev->num_rss +
> +				i % nic_dev->num_rss;

This looks suspicious:

	i is in range [0, HINIC_RSS_INDIR_SIZE)
	so i / HINIC_RSS_INDIR_SIZE is always 0

For the rest please use ethtool_rxfh_indir_default()