linux-kernel - Re: [PATCH 3/3 v6] tty/serial/8250: use mctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190613183405.GT2640@lahna.fi.intel.com>
Date:   Thu, 13 Jun 2019 21:34:05 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Stefan Roese <sr@...x.de>
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yegor Yefremov <yegorslists@...glemail.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Giulio Benetti <giulio.benetti@...ronovasrl.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3/3 v6] tty/serial/8250: use mctrl_gpio helpers

On Thu, Jun 13, 2019 at 05:45:42PM +0200, Stefan Roese wrote:
> From: Yegor Yefremov <yegorslists@...glemail.com>
> 
> This patch permits the usage for GPIOs to control
> the CTS/RTS/DTR/DSR/DCD/RI signals.
> 
> Changed by Stefan:
> Only call mctrl_gpio_init(), if the device has no ACPI companion device
> to not break existing ACPI based systems. Also only use the mctrl_gpio_
> functions when "gpios" is available.
> 
> Use MSR / MCR <-> TIOCM wrapper functions.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@...glemail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Stefan Roese <sr@...x.de>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>