linux-kernel - Re: [PATCH] drm/amd/display: fix compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190613184217.GA2385@ravnborg.org>
Date:   Thu, 13 Jun 2019 20:42:17 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Alex Deucher <alexdeucher@...il.com>
Cc:     Hariprasad Kelam <hariprasad.kelam@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Yongqiang Sun <yongqiang.sun@....com>,
        Charlene Liu <charlene.liu@....com>,
        Leo Li <sunpeng.li@....com>,
        Bhawanpreet Lakha <Bhawanpreet.Lakha@....com>,
        Gloria Li <geling.li@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
        David Airlie <airlied@...ux.ie>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@....com>,
        Tony Cheng <tony.cheng@....com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        Anthony Koo <Anthony.Koo@....com>
Subject: Re: [PATCH] drm/amd/display: fix compilation error

Hi Alex.

On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> <hariprasad.kelam@...il.com> wrote:
> >
> > this patch fixes below compilation error
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > function ‘dcn10_apply_ctx_for_surface’:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > error: implicit declaration of function ‘udelay’
> > [-Werror=implicit-function-declaration]
> >    udelay(underflow_check_delay_us);
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>

Am I right in assuming you took this patch?

I expect that new code using udelay was added to the amd tree,
and when merged with drm-misc-next it failed, because drm-misc-next no
longer had drmP.h included so no implicit include of delay.h

The root cause was that my original patchset should have been based
on the amd tree, and applied there :-(

	Sam