linux-kernel - Re: [PATCH v2 1/7] drivers: regulator: qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190613185136.GW5316@sirena.org.uk>
Date:   Thu, 13 Jun 2019 19:51:36 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Jeffrey Hugo <jeffrey.l.hugo@...il.com>
Cc:     lgirdwood@...il.com, agross@...nel.org, david.brown@...aro.org,
        bjorn.andersson@...aro.org, robh+dt@...nel.org,
        mark.rutland@....com, jorge.ramirez-ortiz@...aro.org,
        niklas.cassel@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 1/7] drivers: regulator: qcom_spmi: enable linear
 range info

On Thu, Jun 06, 2019 at 11:49:23AM -0700, Jeffrey Hugo wrote:

> +		if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_HFS430) {
> +			/* since there is only one range */
> +			range = spmi_regulator_find_range(vreg);
> +			vreg->desc.uV_step = range->step_uV;
> +		}

This doesn't build for me:

drivers/regulator/qcom_spmi-regulator.c: In function ‘qcom_spmi_regulator_probe’:
drivers/regulator/qcom_spmi-regulator.c:1837:29: error: ‘SPMI_REGULATOR_LOGICAL_TYPE_HFS430’ undeclared (first use in this function); did you mean ‘SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS’?
   if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_HFS430) {
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                             SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS
drivers/regulator/qcom_spmi-regulator.c:1837:29: note: each undeclared identifier is reported only once for each function it appears in

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)