linux-kernel - Re: [PATCH] drm/bridge: analogix_dp: possible condition with no effect (if == else)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9bcf16dd-c064-27eb-3749-c3933b4b605f@samsung.com>
Date:   Thu, 13 Jun 2019 15:09:37 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Hariprasad Kelam <hariprasad.kelam@...il.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Marc Zyngier <marc.zyngier@....com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: analogix_dp: possible condition with no
 effect (if == else)

On 25.05.2019 19:59, Hariprasad Kelam wrote:
> fix below warning reported by coccicheck
>
> ./drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1414:6-8: WARNING:
> possible condition with no effect (if == else)
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>


Mixed feelings about it, but:

Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>


I will queue it to drm-misc-next.
 --
Regards
Andrzej


> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 257d69b..cfcd159 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1411,8 +1411,6 @@ static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge,
>  		video->color_space = COLOR_YCBCR444;
>  	else if (display_info->color_formats & DRM_COLOR_FORMAT_YCRCB422)
>  		video->color_space = COLOR_YCBCR422;
> -	else if (display_info->color_formats & DRM_COLOR_FORMAT_RGB444)
> -		video->color_space = COLOR_RGB;
>  	else
>  		video->color_space = COLOR_RGB;
>